[PATCH v4 28/36] media: imx: csi: fix crop rectangle changes in set_fmt

On 02/16/2017 03:05 AM, Russell King - ARM Linux wrote:

On Wed, Feb 15, 2017 at 06:19:30PM -0800, Steve Longerbeam wrote:

quoted

diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c
index ae24b42..3cb97e2 100644
--- a/drivers/staging/media/imx/imx-media-csi.c
+++ b/drivers/staging/media/imx/imx-media-csi.c

@@ -531,6 +531,10 @@ static int csi_setup(struct csi_priv *priv)

 	ipu_csi_set_window(priv->csi, &priv->crop);

+	ipu_csi_set_downsize(priv->csi,
+			     priv->crop.width == 2 * outfmt->width,
+			     priv->crop.height == 2 * outfmt->height);
+

This fails to build:

ERROR: "ipu_csi_set_downsize" [drivers/staging/media/imx/imx-media-csi.ko] undefined!

ipu_csi_set_downsize needs to be exported if we're going to use it in
a module:

Yes I encountered the missing export too, forgot to mention it.
Philipp submitted a patch to dri-devel separately.

Steve