Thread (15 messages) 15 messages, 3 authors, 2017-02-27

[PATCH v3 5/6] ARM: mvebu: Add driver for mv98dx3236-soc-id

From: Chris.Packham@alliedtelesis.co.nz (Chris Packham)
Date: 2017-02-17 04:23:14
Also in: lkml

Hi Arnd,
On 17/02/17 02:28, Arnd Bergmann wrote:
On Thursday, February 16, 2017 9:50:39 PM CET Chris Packham wrote:
quoted
The DFX server on the 98dx3236 and compatible SoCs has an ID register
that provides revision information that the PCI based ID register
doesn't have. Use this if it's available.

Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
How about putting this new code into a separate driver in
drivers/soc/? I don't think you need the early probing we have
here, and not that much is shared otherwise.
Not putting it there means we'll get the pci fall-back behaviour which 
will result in a incorrect rev value. Having said that no callers of 
mvebu_get_soc_id() currently care about these specific SoCs so not 
having the right rev is not an issue at the moment.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help