Thread (2 messages) 2 messages, 2 authors, 2017-02-02

[PATCH v3 2/3] crypto: brcm: Add Broadcom SPU driver

From: herbert@gondor.apana.org.au (Herbert Xu)
Date: 2017-02-02 14:05:29
Also in: linux-crypto, linux-devicetree, lkml

On Wed, Jan 25, 2017 at 11:44:48AM -0500, Rob Rice wrote:
+static int ahash_export(struct ahash_request *req, void *out)
+{
+	const struct iproc_reqctx_s *rctx = ahash_request_ctx(req);
+
+	memcpy(out, rctx, offsetof(struct iproc_reqctx_s, msg_buf));
+	return 0;
+}
The reqctx data structure seems to contain a lot of info unrelated
to the hash state.  Can't we get away with just copying the hash
state (incr_hash) itself?

Cheers,
-- 
Email: Herbert Xu [off-list ref]
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help