Thread (13 messages) 13 messages, 4 authors, 2017-01-11

[PATCH 2/2] media: rc: add driver for IR remote receiver on MT7623 SoC

From: sean.wang@mediatek.com (Sean Wang)
Date: 2017-01-06 07:41:49
Also in: linux-devicetree, linux-media, linux-mediatek, lkml

Hi Andi,

Thank for your reminder. I will refine the code based on your work.
to have elegant code and easy error handling.

Sean

On Fri, 2017-01-06 at 12:43 +0900, Andi Shyti wrote:
Hi Sean,
quoted
+	ir->rc = rc_allocate_device();
Yes, you should use devm_rc_allocate_device(...)

Besides, standing to this patch which is not in yet:

https://lkml.org/lkml/2016/12/18/39

rc_allocate_device should provide the driver type during
allocation, so it should be:

	ir->rc = rc_allocate_device(RC_DRIVER_IR_RAW);

and this line can be removed:
quoted
+	ir->rc->driver_type = RC_DRIVER_IR_RAW;
I don't know when Mauro will take the patch above.

Andi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help