Thread (23 messages) 23 messages, 5 authors, 2017-01-04
STALE3449d

[PATCH v4 06/12] dt: bindings: Add bindings for Marvell Xenon SD Host Controller

From: huziji@marvell.com (Ziji Hu)
Date: 2016-12-22 12:47:07
Also in: linux-mmc

Hi Russell,

On 2016/12/22 19:18, Russell King - ARM Linux wrote:
On Tue, Dec 13, 2016 at 06:48:35PM +0100, Gregory CLEMENT wrote:
quoted
+Optional Properties:
+- mmc-card:
+  mmc-card child node must be provided when current SDHC is for eMMC.
+  Xenon SDHC often can support both SD and eMMC. This child node indicates that
+  current SDHC is for eMMC card. Thus Xenon eMMC specific configuration and
+  operations can be enabled prior to eMMC init sequence.
+  Please refer to Documentation/devicetree/bindings/mmc/mmc-card.txt.
+  This child node should not be set if current Xenon SDHC is for SD/SDIO.
This looks like a typo - shouldn't it be "mmccard" and not "mmc-card"?
Your examples below use "mmccard" as does the documentation you point
towards.
    Thanks a lot for the review.

    I might mix up it with compatible "mmc-card".
    I will change it to sub-node name in next version soon.

    Thank you.

Best regards,
Hu Ziji
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help