Thread (21 messages) 21 messages, 4 authors, 2016-11-03

[PATCH V3 5/6] ARM: tegra: Add Tegra20 GMI support

From: jonathanh@nvidia.com (Jon Hunter)
Date: 2016-11-03 10:29:30
Also in: linux-clk, linux-devicetree, linux-tegra, lkml

On 27/10/16 15:01, Mirza Krak wrote:
quoted hunk ↗ jump to hunk
From: Mirza Krak <redacted>

Add a device node for the GMI controller found on Tegra20.

Signed-off-by: Mirza Krak <redacted>
Tested-by: Marcel Ziswiler <redacted>
Tested-on: Colibri T20/T30 on EvalBoard V3.x and GMI-Memory Board
---

Changes in v2:
- added address-cells, size-cells and ranges properties

Changes in v3:
- fixed range address which is not the same as Tegra30.

 arch/arm/boot/dts/tegra20.dtsi | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi
index 2207c08..b22cddb 100644
--- a/arch/arm/boot/dts/tegra20.dtsi
+++ b/arch/arm/boot/dts/tegra20.dtsi
@@ -1,4 +1,4 @@
-#include <dt-bindings/clock/tegra20-car.h>
+include <dt-bindings/clock/tegra20-car.h>
After fixing up this, can you also ...
quoted hunk ↗ jump to hunk
 #include <dt-bindings/gpio/tegra-gpio.h>
 #include <dt-bindings/pinctrl/pinctrl-tegra.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
@@ -376,6 +376,20 @@
 		status = "disabled";
 	};

+
Drop this additional line?
+	gmi at 70009000 {
+		compatible = "nvidia,tegra20-gmi";
+		reg = <0x70009000 0x1000>;
+		#address-cells = <2>;
+		#size-cells = <1>;
+		ranges = <0 0 0xd0000000 0xfffffff>;
+		clocks = <&tegra_car TEGRA20_CLK_NOR>;
+		clock-names = "gmi";
+		resets = < &tegra_car 42>;
Get rid of this additional space?
+		reset-names = "gmi";
+		status = "disabled";
+	};
+
Otherwise ...

Acked-by: Jon Hunter <jonathanh@nvidia.com>

Cheers
Jon

-- 
nvpublic
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help