Thread (31 messages) 31 messages, 5 authors, 2016-09-20

[PATCH v5 2/9] drivers: irqchip: Add STM32 external interrupts support

From: Thomas Gleixner <hidden>
Date: 2016-09-14 13:36:54
Also in: linux-devicetree, linux-gpio, lkml

On Wed, 14 Sep 2016, Alexandre Torgue wrote:
On 09/14/2016 11:19 AM, Thomas Gleixner wrote:
quoted
Now what really bugs me is that you do that at all. An interrupt which is
freed must be masked already. Why is it unmasked in the first place?
Honestly I don't know. When "devm_free_irq" is called to release virq, there
is no issue and interrupt is well masked. But, when I tried to use
"irq_dispose_mapping(virq)" I observed that .free is called (child and parent
domain) but interrupt is not masked.
Well, you just used some function in some context which is not relevant to
the normal operation. So adding that mask() is just paranoia for no value.

Thanks,

	tglx
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help