Thread (31 messages) 31 messages, 5 authors, 2016-07-25

[PATCH 14/18] ARM: mvebu: add support for the Armada 395 SoC family

flat view

From: Grzegorz Jaszczyk <hidden>
Date: 2016-07-22 09:10:50
Also in: linux-devicetree, lkml

Hi Rob,

2016-07-22 0:16 GMT+02:00 Rob Herring [off-list ref]:
On Thu, Jul 21, 2016 at 02:44:11PM +0200, Grzegorz Jaszczyk wrote:
quoted
-compatible = "marvell,a398-db", "marvell,armada398", "marvell,armada390";
+compatible = "marvell,a398-db", "marvell,armada398", "marvell,armada395", "marvell,armada390";
If 395 came after 398, then it should come first in the order. This
implies that marvell,armada398 is a better match than marvell,armada395.
Or perhaps you shouldn't have both?

Rob
I am not sure if I get your point. The Armada-398 extends the
Armada-395 about 2 additional SATA ports (as you can see in commit
"[PATCH 15/18] ARM: mvebu: a398: update the dtsi about missing
interfaces"). In this example the a398-db board contains the Armada398
SoC, so it is a better match and goes first.

Quite the same is for existing armada-388-db.dts, in which compatible
looks like this:
compatible = "marvell,a385-db", "marvell,armada388",
"marvell,armada385", "marvell,armada380";

In above, Armada-388 also extends the Armada-385 and the order of the
compatible is similar to one from my example.

Thank you,
Grzegorz
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help