Thread (45 messages) 45 messages, 7 authors, 2016-07-21

[PATCH v2 03/10] Clocksource: add nuc970 clocksource driver

From: Daniel Lezcano <hidden>
Date: 2016-07-21 12:52:33
Also in: linux-clk, linux-devicetree, lkml

On Tue, Jul 12, 2016 at 10:28:35AM +0200, Arnd Bergmann wrote:

[ ... ]
quoted
quoted
Also the init function has changed its return type in linux-next:
quoted
+static void __init nuc970_timer_of_init(struct device_node *node)
This now needs to return an error code or we get:

../include/linux/of.h:1004:20: error: comparison of distinct pointer types lacks a cast [-Werror]
         .data = (fn == (fn_type)NULL) ? fn : fn  }

Daniel Lezcano seems to have implemented a migration strategy, but I
can't see what you are supposed to do here, since the
CLOCKSOURCE_OF_DECLARE_RET macro is no longer part of linux-next.
Wait for Daniel's comments? or what should I do now?
Yes, let's see what he says. I guess from the timing, this will probably
have to wait for linux-4.9 anyway, and then we have no problem because the
API change will make it into 4.8.
CLOCKSOURCE_OF_DECLARE_RET was renamed back to CLOCKSOURCE_OF_DECLARE but it 
expects now an init function returning an 'int'.

These changes are now in tip/timers/core, so in linux-next.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help