[PATCH 5/8] uio: fix dmem_region_start computation
From: gregkh@linuxfoundation.org (Greg Kroah-Hartman)
Date: 2016-07-15 11:32:24
Also in:
lkml
On Fri, Jul 15, 2016 at 02:34:00PM +0530, Anup Patel wrote:
From: Jan Viktorin <redacted>
The variable i contains a total number of resources (including
IORESOURCE_IRQ). However, we want the dmem_region_start to point
after the last resource of type IORESOURCE_MEM. The original behaviour
leads (very likely) to skipping several UIO mapping regions and makes
them useless. Fix this by computing dmem_region_start from the uiomem
which points to the last used UIO mapping.
Fixes: 0a0c3b5a24bd ("Add new uio device for dynamic memory allocation")
Signed-off-by: Jan Viktorin <redacted>
---
drivers/uio/uio_dmem_genirq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)Why isn't this patch first in the series, with a stable marking, and your signed off on it (you are forwarding it on to me, so you need to add your mark to it as well, I can't take it otherwise.)
quoted hunk ↗ jump to hunk
diff --git a/drivers/uio/uio_dmem_genirq.c b/drivers/uio/uio_dmem_genirq.c index 915facb..e1134a4 100644 --- a/drivers/uio/uio_dmem_genirq.c +++ b/drivers/uio/uio_dmem_genirq.c@@ -229,7 +229,7 @@ static int uio_dmem_genirq_probe(struct platform_device *pdev) ++uiomem; } - priv->dmem_region_start = i; + priv->dmem_region_start = uiomem - &uioinfo->mem[0];
Are you sure about this? It doesn't look correct at first glance, I'm loath to take this without a bunch of testing. Were you able to test this out to verify it doesn't break working hardware? thanks, greg k-h