[PATCH 1/7] extcon: add missing of_node_put after calling of_parse_phandle
From: Chanwoo Choi <hidden>
Date: 2016-07-02 04:48:07
Also in:
linux-pm, linux-renesas-soc, linux-samsung-soc, lkml
Hi Peter, Applied it. Regards, Chanwoo Choi 2016-07-01 18:41 GMT+09:00 Peter Chen [off-list ref]:
quoted hunk ↗ jump to hunk
of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Cc: MyungJoo Ham <myungjoo.ham@samsung.com> Cc: Chanwoo Choi <cw00.choi@samsung.com> Signed-off-by: Peter Chen <redacted> --- drivers/extcon/extcon.c | 2 ++ 1 file changed, 2 insertions(+)diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index 21a123c..86ea14d 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c@@ -1107,10 +1107,12 @@ struct extcon_dev *extcon_get_edev_by_phandle(struct device *dev, int index) list_for_each_entry(edev, &extcon_dev_list, entry) { if (edev->dev.parent && edev->dev.parent->of_node == node) { mutex_unlock(&extcon_dev_list_lock); + of_node_put(node); return edev; } } mutex_unlock(&extcon_dev_list_lock); + of_node_put(node); return ERR_PTR(-EPROBE_DEFER); } --1.9.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel at lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel