[PATCH 2/7] arm: mach-shmobile: pm-rmobile: add missing of_node_put after calling of_parse_phandle
From: geert@linux-m68k.org (Geert Uytterhoeven)
Date: 2016-07-01 12:32:43
Also in:
linux-pm, linux-renesas-soc, linux-samsung-soc, lkml
Hi Peter, On Fri, Jul 1, 2016 at 11:41 AM, Peter Chen [off-list ref] wrote:
of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Cc: Simon Horman <horms@verge.net.au> Cc: Magnus Damm <magnus.damm@gmail.com> Signed-off-by: Peter Chen <redacted>
NAKed-by: Geert Uytterhoeven [off-list ref]
quoted hunk ↗ jump to hunk
--- a/arch/arm/mach-shmobile/pm-rmobile.c +++ b/arch/arm/mach-shmobile/pm-rmobile.c@@ -209,6 +209,7 @@ static void __init add_special_pd(struct device_node *np, enum pd_types type) special_pds[num_special_pds].pd = pd;
The pd pointer is stored in the line above, and released later in put_special_pds().
special_pds[num_special_pds].type = type;
num_special_pds++;
+ of_node_put(pd);
Hence it must not be released here, as that would cause a double release
when put_special_pds() is executed.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds