Thread (12 messages) flat view 12 messages, 6 authors, 2016-06-27
STALE3726d REVIEWED: 1 (0M)

1 review trailer.

[RFC PATCH] clocksource: arm_arch_timer: disable the evtstrm via the cmdline

From: Marc Zyngier <hidden>
Date: 2016-06-20 08:34:53

On Mon, 20 Jun 2016 09:21:57 +0100
Will Deacon [off-list ref] wrote:
On Sun, Jun 19, 2016 at 10:08:38PM +0200, Daniel Lezcano wrote:
quoted
On 06/17/2016 03:43 PM, Will Deacon wrote:

[ Cc'ed tglx ]
quoted
Disabling the eventstream can be useful for debugging and development
purposes
If it is for debugging and development, why upstream this change ?
Mainly because it's desirable to be able to debug systems remotely, on
machines that you don't have direct access to and where recompiling the
kernel isn't necessarily an option. There are plenty of "no*" kernel
parameters already that fall into a similar category.
I would add that being able to toggle this without affecting the memory
layout or any of the code paths is extremely valuable. The event stream
can have an effect on the spinlock behaviour (through the WFE
instruction), so having a way to exercise it without changing anything
else is pretty cool. Also, being able to debug a production kernel at
zero cost is rare enough to make me jump on the opportunity.

So for this patch, and Mark's suggestion of adding some documentation
to it:

Acked-by: Marc Zyngier <redacted>

	M.
-- 
Jazz is not dead. It just smells funny.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help