Hi Emil,

Thanks for your review.

On Fri, 2016-05-27 at 10:24 +0100, Emil Velikov wrote:

On 27 May 2016 at 08:31, YT Shen [off-list ref] wrote:

quoted

Hi CK,


On Mon, 2016-05-23 at 17:43 +0800, CK Hu wrote:

quoted

Hi, YT:

One comment below.

On Fri, 2016-05-20 at 23:05 +0800, yt.shen at mediatek.com wrote:

quoted

From: YT Shen <redacted>

There are some hardware settings changed, between MT8173 & MT2701:
DISP_OVL address offset changed, color format definition changed.
DISP_RDMA fifo size changed.
DISP_COLOR offset changed.

Signed-off-by: YT Shen <redacted>
---
+
+static inline struct mtk_ddp_comp_driver_data *mtk_ovl_get_driver_data(
+   struct platform_device *pdev)
+{
+   const struct of_device_id *of_id =
+           of_match_device(mtk_disp_ovl_driver_dt_match, &pdev->dev);
+
+   return (struct mtk_ddp_comp_driver_data *)of_id->data;
+}
+
+static inline struct mtk_ddp_comp_driver_data *mtk_rdma_get_driver_data(
+   struct platform_device *pdev)
+{
+   const struct of_device_id *of_id =
+           of_match_device(mtk_disp_rdma_driver_dt_match, &pdev->dev);
+
+   return (struct mtk_ddp_comp_driver_data *)of_id->data;
+}
+
+static inline struct mtk_ddp_comp_driver_data *mtk_color_get_driver_data(
+   struct device_node *node)
+{
+   const struct of_device_id *of_id =
+           of_match_node(mtk_disp_color_driver_dt_match, node);
+
+   return (struct mtk_ddp_comp_driver_data *)of_id->data;
+}
+

These three functions looks the same with different parameter:
mtk_disp_ovl_driver_dt_match, mtk_disp_rdma_driver_dt_match, and
mtk_disp_color_driver_dt_match. So merge them to prevent duplicated
code.

OK, I'll do this in the next version.

Also preserve the const-ness of the data - don't cast it away on the
return line.
Note that the function return type (and some of the users of said
functions) should be updated as well.

OK, I will check this part.

-Emil