[PATCH v2 2/5] arm64: add ARMv8.2 id_aa64mmfr2 boiler plate

On March 4, 2016 9:59:28 AM EST, Mark Rutland [off-list ref] wrote:

On Thu, Mar 03, 2016 at 02:03:08PM -0500, Christopher Covington wrote:

quoted

On 03/03/2016 01:27 PM, Robin Murphy wrote:

quoted

On 03/03/16 17:59, Christopher Covington wrote:

quoted

quoted

quoted

--- a/arch/arm64/kernel/cpuinfo.c
+++ b/arch/arm64/kernel/cpuinfo.c

@@ -210,6 +210,7 @@ static void __cpuinfo_store_cpu(struct

cpuinfo_arm64 *info)
      info->reg_id_aa64isar1 = read_cpuid(SYS_ID_AA64ISAR1_EL1);
      info->reg_id_aa64mmfr0 = read_cpuid(SYS_ID_AA64MMFR0_EL1);
      info->reg_id_aa64mmfr1 = read_cpuid(SYS_ID_AA64MMFR1_EL1);
+    info->reg_id_aa64mmfr2 = read_cpuid(SYS_ID_AA64MMFR2_EL1);
      info->reg_id_aa64pfr0 = read_cpuid(SYS_ID_AA64PFR0_EL1);
      info->reg_id_aa64pfr1 = read_cpuid(SYS_ID_AA64PFR1_EL1);

swapper[0]: undefined instruction: pc=ffffff800808d730
Code: d5380702 d5380721 f9017c02 f9018001 (d5380742)
Internal error: Oops - undefined instruction: 0 [#1] PREEMPT SMP
Modules linked in:
CPU: 0 PID: 0 Comm: swapper Not tainted 4.5.0-rc6-next-20160303 #1
Hardware name: (null) (DT)
task: ffffff8008b2d980 ti: ffffff8008b20000 task.ti:

ffffff8008b20000

quoted

quoted

quoted

PC is at __cpuinfo_store_cpu+0x68/0x198
LR is at cpuinfo_store_boot_cpu+0x28/0x50

ffffff800808d730:       d5380742        mrs     x2, s3_0_c0_c7_2

Hmm, per table C5-6 in the ARMv8 ARM (issue i), that's specifically

a

quoted

quoted

reserved encoding, rather than an unallocated one, so it should

read as

quoted

quoted

zero, not undef. What are you running on?

QDF2432. I'll investigate.

Just to check, I take it you're running natively, and not under a
hypervisor?

Yes this was running natively. I haven't yet been able to confirm things, but I'll let you know when I do.

Cov

-- 
Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Sent from my Snapdragon powered Android device with K-9 Mail. Please excuse my brevity.