On 03/17/2016 08:11 AM, Sergei Shtylyov wrote:

On 3/17/2016 5:26 AM, David Lechner wrote:

quoted

      glue->dev            = &pdev->dev;
      pdata->platform_ops        = &da8xx_ops;

-    glue->phy = usb_phy_generic_register();
-    if (IS_ERR(glue->phy)) {
-        ret = PTR_ERR(glue->phy);
-        goto err5;
+    glue->usb_phy = usb_phy_generic_register();

    Hm, do we still need the USB PHY? It does nothing IIRC...

Unfortunately, yes. It is used in musb_core, etc., mainly for otg->state.