Thread (45 messages) 45 messages, 6 authors, 2016-02-19

[PATCH v3 05/10] serial: mps2-uart: add support for early console

From: Andy Shevchenko <hidden>
Date: 2016-02-19 09:57:51
Also in: linux-api, linux-devicetree, linux-serial, lkml

On Fri, Feb 19, 2016 at 11:45 AM, Vladimir Murzin
[off-list ref] wrote:
On 16/02/16 13:09, Vladimir Murzin wrote:
quoted
quoted
quoted
+EARLYCON_DECLARE(mps2, mps2_early_console_setup);
quoted
quoted
+OF_EARLYCON_DECLARE(mps2, "arm,mps2-uart", mps2_early_console_setup);
IIRC Peter Hurley mentioned you don't need to put both anymore, OF_
one is enough.
I've just tried with OF_ only and seems it works fine. Thanks for
pointing at it!
..and the reason for that was that I had stdout pointing at uart node.
Now, while testing v4 I end-up with configuration:

1) no EARLYCON_DECLARE in mps2-uart.c
2) stdout not set
3) cmdline has "earlycon=mps2,0x40004000 console=/dev/ttyMPS"

and I don't see bootconsole, but if I avoid 1) everything works fine.
So, I'd leave EARLYCON_DECLARE in this patch.
Peter, what is your comment on this?


-- 
With Best Regards,
Andy Shevchenko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help