[PATCH v4 1/2] regulator: act8945a: add regulator driver for ACT8945A
From: broonie@kernel.org (Mark Brown)
Date: 2016-02-03 17:48:17
Also in:
linux-devicetree, lkml
On Wed, Feb 03, 2016 at 02:33:11AM +0000, Yang, Wenyou wrote:
quoted
I would just remove the "active-semi,act8945a-regulator" node and make "active- semi,vsel-high" a property of the "active-semi,act8945a" node. That way you can remove the mfd cell .of_compatible and OF table in the regulator driver and read the "active-semi,vsel-high" using the platform device's parent of_node.
quoted
But it's better if you wait for Mark's opinions before re-spining your patches.
Hi Mark, what is your opinions?
Like Javier says you should make your DT binding look like the DT bindings for other MFDs and not use of_compatible. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 473 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160203/30814480/attachment.sig>