Hi Mark,

-----Original Message-----
From: Mark Brown [mailto:broonie at kernel.org]
Sent: 2016?1?29? 8:16
To: Yang, Wenyou <redacted>
Cc: Liam Girdwood <lgirdwood@gmail.com>; Rob Herring <robh+dt@kernel.org>;
Pawel Moll [off-list ref]; Ian Campbell
[off-list ref]; Kumar Gala [off-list ref];
Krzysztof Kozlowski [off-list ref]; Javier Martinez Canillas
[off-list ref]; Lee Jones [off-list ref]; Peter Korsgaard
[off-list ref]; Ferre, Nicolas [off-list ref]; linux-arm-
kernel at lists.infradead.org; linux-kernel at vger.kernel.org;
devicetree at vger.kernel.org
Subject: Re: [PATCH v4 1/2] regulator: act8945a: add regulator driver for
ACT8945A

On Wed, Jan 27, 2016 at 10:57:42AM +0800, Wenyou Yang wrote:

quoted

+static const struct of_device_id act8945a_pmic_of_match[] = {
+	{ .compatible = "active-semi,act8945a-regulator" },
+	{ },
+};
+MODULE_DEVICE_TABLE(of, act8945a_pmic_of_match);

This seems mostly OK but why do we have a compatible string here - shouldn't
the MFD be able to instantiate the regulator function without needing this?

Because I got feedback from Javier for the act8945a-charger patches of this MFD series,
He said missing the OF match table will cause the module autoloading broken. 

http://lists.infradead.org/pipermail/linux-arm-kernel/2016-January/398113.html

What do you think about it?


Best Regards,
Wenyou Yang