Thread (31 messages) flat view 31 messages, 6 authors, 2016-02-04

[PATCH V2 3/5] PCI: xilinx: Modifying AXI PCIe Host Bridge driver to work on both Zynq and Microblaze

From: arnd@arndb.de (Arnd Bergmann)
Date: 2016-01-27 15:17:48
Also in: linux-devicetree, linux-pci, lkml

On Wednesday 27 January 2016 14:33:45 Bharat Kumar Gogada wrote:
quoted
quoted
@@ -705,7 +715,9 @@ static int xilinx_pcie_probe(struct
platform_device *pdev)  #endif
    pci_scan_child_bus(bus);
    pci_assign_unassigned_bus_resources(bus);
+#ifdef CONFIG_ARM
    pci_fixup_irqs(pci_common_swizzle, of_irq_parse_and_map_pci);
+#endif
    pci_bus_add_devices(bus);
    platform_set_drvdata(pdev, port);
Here it looks like microblaze gets it right. I'm not sure why we still need the
pci_fixup_irqs() on ARM, but my feeling is that this should be fixed in
common code.
In arm pci_fixup_irqs is called by pci_common_init_dev (arch/arm/kernel/bios32.c), since this API is removed now, I was calling it separately.
But who calls it in microblaze? If it works without the extra call there,
can we make it work the same way for ARM?

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help