[PATCH v3 08/12] arm64, numa: rework numa_add_memblk()
From: Robert Richter <hidden>
Date: 2016-01-25 10:07:59
Also in:
linux-acpi, lkml
On 23.01.16 17:39:23, Hanjun Guo wrote:
Rework numa_add_memblk() to update the parameter "u64 size" to "u64 end", this will make it consistent with x86 and can simplify the code later.
quoted hunk ↗ jump to hunk
--- a/arch/arm64/kernel/of_numa.c +++ b/arch/arm64/kernel/of_numa.c@@ -168,7 +168,7 @@ static int __init early_init_parse_memory_node(unsigned long node) pr_debug("NUMA-DT: base = %llx , node = %u\n", base, nid); - if (numa_add_memblk(nid, base, size) < 0) + if (numa_add_memblk(nid, base, base + size) < 0)
The overall function usage looks more like as it should use size instead of end. Even in the x86 implementation end is calculated from base + size. So better change x86 code to use size instead. Though this might involve to change the interface for numa_add_memblk_to() for unifcation too. -Robert