Thread (36 messages) 36 messages, 6 authors, 2016-03-10

[PATCH v3 04/12] acpi, numa: introduce ACPI_HAS_NUMA_ARCH_FIXUP

From: Hanjun Guo <hidden>
Date: 2016-01-24 04:56:16
Also in: linux-acpi, lkml

On 01/23/2016 06:25 PM, Robert Richter wrote:
On 23.01.16 17:39:19, Hanjun Guo wrote:
quoted
From: Hanjun Guo <redacted>

acpi_numa_arch_fixup() is only used for IA64, x86 introduce a dummy
function for it, when we came to a new architecture (such as ARM64),
we need to introduce another dummy one to make the code compile.

That's pretty boring so introduce ACPI_HAS_NUMA_ARCH_FIXUP and
select it for IA64, introduce a stub function for acpi_numa_arch_fixup()
then it's pretty clean for x86 and ARM64.

Signed-off-by: Hanjun Guo <redacted>
---
  arch/ia64/Kconfig    | 1 +
I see an implementation of acpi_numa_arch_fixup() only for ia64. Why
not move it to arch/ia64 then and call it from setup_arch() in
arch/ia64/kernel/setup.c after acpi_numa_init()? It looks like we
don't need a generic solution for this. This avoids any kconfig
handling for this at all.
It's much simpler as you suggested, I will update it in next
version, thank you Robert :)

Hanjun
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help