On 01/14/2016 05:33 PM, Lorenzo Pieralisi wrote:

On Wed, Jan 13, 2016 at 02:21:00PM +0100, Tomasz Nowicki wrote:

quoted

Arches in subject are the only one who use pcibios_{add|remove}_bus hooks

"x86 and ia64 are the only arches that implement..."

quoted

and implement it in the same way. Moreover ARM64 is going to do the same.

"implement them"

quoted

So it seams that acpi_pci_{add|remove}_bus is generic enough to be default

s/seams/seems

quoted

option for pcibios_{add|remove}_bus hooks. Also, it is always safe to run
acpi_pci_{add|remove}_bus as they have empty stubs for !ACPI case and
return if ACPI has been switched off in run time.

After all we can remove x86 and ia64 pcibios_{add|remove}_bus
implementation.

I think you should rephrase the commit log and fix the typos.

yes, I will.

quoted

Signed-off-by: Tomasz Nowicki <redacted>
---
  arch/ia64/pci/pci.c   | 10 ----------
  arch/x86/pci/common.c | 10 ----------
  drivers/pci/probe.c   |  3 +++
  3 files changed, 3 insertions(+), 20 deletions(-)

Patch seems fine to me, I do not see why moving the acpi calls into
generic code would create issues (and why it has not been done before)
as you mentioned in the commit log, so:

Reviewed-by: Lorenzo Pieralisi <redacted>

Thanks,
Tomasz