[PATCH v2 1/2] regulator: act8945a: add regulator driver for ACT8945A

-----Original Message-----
From: Peter Korsgaard [mailto:jacmet at gmail.com] On Behalf Of Peter Korsgaard
Sent: 2016?1?14? 15:28
To: Yang, Wenyou <redacted>
Cc: Liam Girdwood <lgirdwood@gmail.com>; Mark Brown <broonie@kernel.org>;
Rob Herring [off-list ref]; Pawel Moll [off-list ref]; Mark
Rutland [off-list ref]; Ian Campbell [off-list ref];
Kumar Gala [off-list ref]; Krzysztof Kozlowski
[off-list ref]; devicetree at vger.kernel.org; Ferre, Nicolas
[off-list ref]; linux-kernel at vger.kernel.org; Javier Martinez
Canillas [off-list ref]; Lee Jones [off-list ref]; linux-arm-
kernel at lists.infradead.org
Subject: Re: [PATCH v2 1/2] regulator: act8945a: add regulator driver for
ACT8945A

quoted

quoted

quoted

quoted

quoted

"Yang," == Yang, Wenyou [off-list ref] writes:

 >> Isn't the regulator part of the act8945a identical to act8865? Can't we just use
the  >> existing act8865-regulator.c driver? (E.G. support 8865 variant in the mfd
driver,  >> but only register the regulator sub device?)

 > Yes, the regulator part of the act8945a is identical to act8865.

 > But the act8865-regulator driver is a struct i2c_driver, and the mfd  > sub-
device driver is a platform_driver driver, it is not easy to use  > it.

But the mfd driver could support the act8865 variant as well (by only registering
the regulator mfd cell).

I still don't understand.

The MFD sub device is registered as a platform device, the existing act8865 driver is registered as an i2c_driver. How do they match? :)

Could you point out which exiting driver for me to reference.  Thank you!


Best Regards,
Wenyou Yang