Thread (31 messages) 31 messages, 5 authors, 2016-01-13

[PATCH v1 3/3] ARM64 LPC: update binding doc

From: benh@kernel.crashing.org (Benjamin Herrenschmidt)
Date: 2016-01-13 06:14:19
Also in: linux-devicetree, lkml

On Tue, 2016-01-12 at 23:52 +0100, Arnd Bergmann wrote:
On Tuesday 12 January 2016 15:13:35 liviu.dudau at arm.com?wrote:
quoted
quoted
int of_address_to_resource(struct device_node *dev, int index,
????????????????????????? struct resource *r)
{
?????? ...
?????? /* flags can be get here, without ranges property reqired.
??????? * if the reg = <0x0 0xe4 4>, I can get flag of
IORESOURCE_MEM,
quoted
quoted
??????? * if the reg = <0x1 0xe4 4>, I can get flag of
IORESOURCE_IO,
quoted
?
That is strange, the parent node has #address-cells = <2> so the
first two numbers should be part
quoted
of the address and not influence the flags. Can you add some
debugging in of_get_address() and
quoted
try to figure out what bus is used in? *flags = bus-
get_flags(prop) ?
?
?
This is the standard ISA binding. The first cell is the address space
(IO or MEM), the second cell is the address within that space. This
is similar to how PCI works.
Picking up that mid-way, I have LPC busses on power and am using a
similar binding. I'll try to grab some examples and review the
document tomorrow (only just noticed it while unpiling emails post-
vacation).

Cheers,
Ben.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help