[PATCH v3 1/3] spi: atmel: add support for the internal chip-select of the spi controller
flat view
From: broonie@kernel.org (Mark Brown)
Date: 2016-01-07 15:42:09
Also in:
linux-devicetree, linux-spi, lkml
On Tue, Jan 05, 2016 at 09:50:54PM +0000, M?ns Rullg?rd wrote:
Cyrille Pitchen [off-list ref] writes:
quoted
+ as->use_cs_gpios = true; + if (atmel_spi_is_v2(as) && + !of_get_property(pdev->dev.of_node, "cs-gpios", NULL)) { + as->use_cs_gpios = false; + master->num_chipselect = 4; + }
This part breaks the AVR32 boards and probably anything else that doesn't use devicetree but does use GPIOs for chip select.
Shouldn't this just be setting defaults for the case where nothing is provided? -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 473 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160107/bebfccd1/attachment.sig>