On Thu, Dec 24, 2015 at 04:07:05PM +0000, Russell King - ARM Linux wrote:

On Thu, Dec 24, 2015 at 03:54:32PM +0000, Russell King - ARM Linux wrote:

quoted

On Thu, Dec 24, 2015 at 09:50:16AM -0600, Timur Tabi wrote:

quoted

On Thu, Dec 24, 2015 at 9:40 AM, Russell King - ARM Linux
[off-list ref] wrote:

quoted

quoted

        while (readl(port->membase + REG_FR) & UART01x_FR_TXFF)

is broken because REG_FR is equal to 1.

Patch 4, which changes to the REG_* stuff, does not (explicitly) touch
this because it _will_ break stuff.

I'm just telling you what's in Greg's tty-next repository:

https://git.kernel.org/cgit/linux/kernel/git/gregkh/tty.git/log/drivers/tty/serial/amba-pl011.c?h=tty-next

https://git.kernel.org/cgit/linux/kernel/git/gregkh/tty.git/tree/drivers/tty/serial/amba-pl011.c?h=tty-next#n2302

I wonder where Greg got those patches from, because it's not _this_ patch
set (I checked patch 4 from this posting before my previous reply.)

Based on just that, Greg seems to have picked up the old series from
November 3rd, not this series from November 16th...  So you have the
problems from the first series. :(

Okay, what I'm going to do is push out my set of patches into
linux-next, which will conflict with what Greg's merged, and we
should end up with a report of the differences between the two.
That should then let us see what changes are needed for Greg's tree.

-- 
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.