[PATCH v4 04/24] hwmon: pwm-fan: use pwm_get_xxx() helpers where appropriate
From: Boris Brezillon <hidden>
Date: 2015-11-16 16:53:30
Also in:
linux-clk, linux-fbdev, linux-input, linux-leds, linux-pwm, linux-rockchip, lkml
On Mon, 16 Nov 2015 07:59:23 -0800 Guenter Roeck [off-list ref] wrote:
On 11/16/2015 12:56 AM, Boris Brezillon wrote:quoted
Use pwm_get_xxx() helpers instead of directly accessing the pwm->xxx field. Doing that will ease adaptation of the PWM framework to support atomic update. Signed-off-by: Boris Brezillon <redacted> --- Patch generated with the following coccinelle script: --->8--- virtual patch @@ struct pwm_device *p; expression e; @@ ( -(p)->polarity = e; +pwm_set_polarity((p), e); | -(p)->polarity +pwm_get_polarity((p))s/((p))/(p)/quoted
| -(p)->period = e; +pwm_set_period((p), e); | -(p)->period +pwm_get_period((p))s/((p))/(p)/quoted
| -(p)->duty_cycle = e; +pwm_set_duty_cycle((p), e);The (p) seems unnecessary here.
I don't get this one. You mean I should drop one the parenthesis around p, right? -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com