[PATCH RESEND v2 3/4] ARM: BCM: Add SMP support for Broadcom NSP

2015-11-09 2:09 GMT-08:00 Linus Walleij [off-list ref]:

On Fri, Nov 6, 2015 at 8:49 PM, Kapil Hali [off-list ref] wrote:

quoted

Add SMP support for Broadcom's Northstar Plus SoC
cpu enable method. This changes also consolidates
iProc family's - BCM NSP and BCM Kona, platform
SMP handling in a common file.

Northstar Plus SoC is based on ARM Cortex-A9
revision r3p0 which requires configuration for ARM
Errata 764369 for SMP. This change adds the needed
configuration option.

Signed-off-by: Kapil Hali <redacted>

This version looks saner to me.

quoted

+static int nsp_write_lut(void)
+{
+       void __iomem *sku_rom_lut;
+       phys_addr_t secondary_startup_phy;
+
+       if (!secondary_boot) {
+               pr_warn("required secondary boot register not specified\n");
+               return -EINVAL;
+       }
+
+       sku_rom_lut = ioremap_nocache((phys_addr_t)secondary_boot,
+                                               sizeof(secondary_boot));

Why is this address not just taken directly from the device tree?

It comes directly from DT, that's what bcm_smp_prepare_cpus() does
read from Device Tree.

If it is not in the device tree: why?

Also give it a sane name, bcm_sec_boot_address or so.
"secondary_boot" sounds like a function you call to boot
the second core.

Agree with that, there could be a better name which better reflects
this is a variable.
-- 
Florian