[PATCH v2 8/9] ARM: dts: Add leds support to STM32F429 Discovery board
From: mcoquelin.stm32@gmail.com (Maxime Coquelin)
Date: 2015-10-28 14:24:08
Also in:
linux-devicetree, linux-gpio, lkml
From: mcoquelin.stm32@gmail.com (Maxime Coquelin)
Date: 2015-10-28 14:24:08
Also in:
linux-devicetree, linux-gpio, lkml
2015-10-28 9:09 GMT+01:00 Daniel Thompson [off-list ref]:
On 27/10/15 21:52, Andreas F?rber wrote:quoted
Am 27.10.2015 um 22:46 schrieb Linus Walleij:quoted
Heartbeat is awesome.Yes, it's awesome for testing, but not for a .dts file that ends up in a distro (not the case here, of course) and keeps blinking on the desk. If someone wants LEDs to blink, they can set that via sysfs or by modifying their .dts locally. sunxi chose to keep LEDs off my default. For qcom we had a similar discussion some weeks ago. I don't regularly read Linux patches, so feel free to skim the archives yourself.Among the existing DTS files there is pretty significant use of heartbeat although its not absolute. There are 119 files that set a default-trigger, of these 91 (~75%) include a line to configure a heartbeat. Personally I'd be very happy with heartbeat by default on STM32... I've seldom worked on a board without a default-enabled heartbeat so they make me feel comfortable. ;-)
I will add heartbeat in next version, which will arrive when the pinctrl driver first review is done. Thanks, Maxime