2015-10-26 14:41 GMT+01:00 Linus Walleij [off-list ref]:

On Sat, Oct 17, 2015 at 7:23 PM, Maxime Coquelin
[off-list ref] wrote:

quoted

Signed-off-by: Maxime Coquelin <mcoquelin.stm32@gmail.com>

(...)

quoted

+       leds {
+               compatible = "gpio-leds";
+               red {
+                       gpios = <&gpiog 14 0>;
+               };
+               green {
+                       gpios = <&gpiog 13 0>;
+               };

I suggest you add labels to these LEDs.

label = "red-LED"
label = "green-LED"

This make things so much easier in sysfs.

I'm not sure to understand where it makes things easier in sysfs.
This is the sysfs path for the red led:
/sys/class/leds/red/

Indeed, if label is not present, it gets the node name.

Usually people also want to add a default linux,trigger to these,
like linux,default-trigger = "heartbeat"; but whatever you prefer.

Makes sense, I will add default trigger in next version.

Acked-by: Linus Walleij <redacted>

Thanks!
Maxime