Thread (15 messages) 15 messages, 5 authors, 2015-09-30
STALE3920d

[PATCH/RFC v2 net-next 3/4] ravb: Document binding for r8a7795 SoC

From: horms@verge.net.au (Simon Horman)
Date: 2015-09-11 08:53:12
Also in: linux-sh, netdev

On Fri, Sep 11, 2015 at 10:41:31AM +0200, Geert Uytterhoeven wrote:
Hi Simon,

On Fri, Sep 11, 2015 at 10:14 AM, Simon Horman [off-list ref] wrote:
quoted
quoted
quoted
@@ -18,6 +21,9 @@ Required properties:
 Optional properties:
 - interrupt-parent: the phandle for the interrupt controller that services
                    interrupts for this device.
+- interrupt-names: One entry per interrupt named "ch%u".
+                  For the R8A7795 SoC this property is mandatory,
+                  and "ch0" through "ch24" are mandatory.
This suggests the single multiplexed interrupt on R-Car Gen2 can be called
"ch0". Is that what you want? I know the driver doesn't care.
No, its not what I intended.

I think its reasonable to allow the multiplexed interrupt to be named,
but to what I wonder. The documentation seems to call the interrupt
"EthernetAVB", which isn't very exciting.
Perhaps "mux", like I did for rspi, cfr.
Documentation/devicetree/bindings/spi/spi-rspi.txt:

  - interrupts       : A list of interrupt-specifiers, one for each entry in
                       interrupt-names.
                       If interrupt-names is not present, an interrupt specifier
                       for a single muxed interrupt.
  - interrupt-names  : A list of interrupt names. Should contain (if present):
                         - "error" for SPEI,
                         - "rx" for SPRI,
                         - "tx" to SPTI,
                         - "mux" for a single muxed interrupt.
Thanks for for that example. "mux" sounds good to me.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help