[PATCH/RFC v2 net-next 1/4] phylib: Add phy_set_max_speed helper
From: f.fainelli@gmail.com (Florian Fainelli)
Date: 2015-09-11 04:14:34
Also in:
linux-sh, netdev
Le 09/10/15 19:01, Simon Horman a ?crit :
Add a helper to allow ethernet drivers to limit the speed of a phy (that they are attached to). This mainly involves factoring out the business-end of of_set_phy_supported() and exporting a new symbol. This code seems to be open coded in several places, in several different variants. This code is envisaged this will be used in situations where setting the "max-speed" property is not appropriate, e.g. because the maximum speed is not a property of the phy hardware.
This looks good to me, one minor comment, see below:
quoted hunk ↗ jump to hunk
Signed-off-by: Simon Horman <redacted> --- v2 * First post --- drivers/net/phy/phy_device.c | 52 ++++++++++++++++++++++++++++---------------- include/linux/phy.h | 1 + 2 files changed, 34 insertions(+), 19 deletions(-)diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index c0f211127274..d9a020095972 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c@@ -1205,6 +1205,37 @@ static int gen10g_resume(struct phy_device *phydev) return 0; } +static void __set_phy_supported(struct phy_device *phydev, u32 max_speed) +{ + if (!IS_ENABLED(CONFIG_OF_MDIO)) + return;
I think that part should be moved to of_set_phy_supported(), since your are exporting phy_set_max_speed() which should therefore be available regardless of whether Device Tree is used. While you are it, it might be nice to either warn or return -ENOTSUPP if the speed does not match 10, 100 or 1000, but that might be worth a second patch. Thanks! -- Florian