Thread (41 messages) 41 messages, 4 authors, 2015-10-13

[PATCH v2 1/9] dmaengine: st_fdma: Add STMicroelectronics FDMA DT binding documentation

From: arnd@arndb.de (Arnd Bergmann)
Date: 2015-09-11 20:36:40
Also in: linux-devicetree, lkml

On Friday 11 September 2015 15:14:23 Peter Griffin wrote:
+- st,fdma-id	: Must contain fdma controller number
What for?
+Example:
+
+	fdma1: fdma-app at 8e40000 {
The name should be "dma-controller", not "fdma-app".
+Example:
+
+	snd_uni_player2: snd-uni-player at 2 {
+		compatible = "st,snd_uni_player";
Maybe change the compatible string to "st,snd-uni-player"?

The string you use here would not be acceptable for a binding.

	Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help