On Mon, Aug 24, 2015 at 7:45 PM, Marek Vasut [off-list ref] wrote:

On Monday, August 24, 2015 at 07:04:38 PM, Cyrille Pitchen wrote:

quoted

Hi Marek,

Hi!

quoted

Le 24/08/2015 13:03, Marek Vasut a ?crit :

quoted

On Monday, August 24, 2015 at 12:14:00 PM, Cyrille Pitchen wrote:

quoted

This driver add support to the new Atmel QSPI controller embedded into
sama5d2x SoCs. It expects a NOR memory to be connected to the QSPI
controller.

[...]

quoted

quoted

quoted

+  /* Compute address parameters */
+  switch (cmd->enable.bits.address) {
+  case 4:
+          ifr |= QSPI_IFR_ADDRL;
+          /*break;*/ /* fallback to the 24bit address case */

What's this commented out bit of code for ? :-)

I just wanted to stress out there was no missing "break;".
I've reworded the comment to:
/* No "break" on purpose: fallback to the 24bit address case. */

Oh, the address is in bytes . I see, yes, it makes sense to be more
explicit here about the purpose of the fallback. I think this change
in the comment will make it easier for everyone who comes back in a
few years and reads this code.

I think you are looking for the term "(switch case) fallthrough", not
"fallback". "Fallback" makes it sound like there is something missing,
or an invalid state.


Jonas