[PATCH linux-next v4 5/5] mtd: atmel-quadspi: add driver for Atmel QSPI controller
From: Russell King - ARM Linux <hidden>
Date: 2015-08-24 12:49:57
Also in:
linux-devicetree, linux-spi, lkml
From: Russell King - ARM Linux <hidden>
Date: 2015-08-24 12:49:57
Also in:
linux-devicetree, linux-spi, lkml
On Mon, Aug 24, 2015 at 01:03:51PM +0200, Marek Vasut wrote:
These are functions, not macros :) btw is there any reason for these ? I'd say, just put the read*() and write*() functions directly into the code and be done with it, it is much less confusing. Also, why do you use the _relaxed() versions of the functions ?
Now that the _relaxed() accessors are available throughout the kernel, everyone should be using the _relaxed() versions unless they need the properties of the non-relaxed versions. Remember that the non-relaxed versions are rather expensive on ARM due to the need to go all the way out to the L2 cache - it at least doubles the number of accesses for every read*/write*(). -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net.