[PATCH v4 3/3] touchscreen: colibri-vf50-ts: Add touchscreen support for Colibri VF50
From: stefan@agner.ch (Stefan Agner)
Date: 2015-08-23 01:52:45
Also in:
linux-devicetree, linux-input, lkml
From: stefan@agner.ch (Stefan Agner)
Date: 2015-08-23 01:52:45
Also in:
linux-devicetree, linux-input, lkml
Hi Sanchayan, On 2015-08-21 06:26, Sanchayan Maity wrote:
+static int vf50_ts_probe(struct platform_device *pdev)
+{
+ struct input_dev *input;
+ struct iio_channel *channels;
+ struct device *dev = &pdev->dev;
+ struct vf50_touch_device *touchdev;
+ int error;
+
+ channels = iio_channel_get_all(dev);
+ if (IS_ERR(channels))
+ return PTR_ERR(channels);Hm, we expect here that four channels are returned, however a faulty device tree could contain less. Access to the fourth channel above would lead to a bug. Can you check the amount of channels returned? The returned list is explicitly terminated with a null entry, you can rely on that. Something similar to hwmon should do the job. http://lxr.free-electrons.com/source/drivers/hwmon/iio_hwmon.c#L86 Otherwise, Acked-by: Stefan Agner [off-list ref] -- Stefan