On 08/17/2015 11:58 AM, Anirudha Sarangi wrote:

Hi,

quoted

-----Original Message-----
From: Peter Hurley [mailto:peter at hurleysoftware.com]
Sent: Monday, August 17, 2015 9:20 PM
To: Michal Simek
Cc: linux-kernel at vger.kernel.org; monstr at monstr.eu; Anirudha Sarangi; Soren
Brinkmann; Jiri Slaby; linux-serial at vger.kernel.org; Greg Kroah-Hartman; linux-
arm-kernel at lists.infradead.org
Subject: Re: [PATCH 2/4] serial: xuartps: Do not handle overrun errors under
IGNPAR option

On 08/17/2015 03:22 AM, Michal Simek wrote:

quoted

From: Anirudha Sarangi <redacted>

The existing implementation includes overrun errors under IGNPAR
option. This patch fixes it by including only parity and framing error
under IGNPAR option.

The convention adopted by Linux serial drivers is to ignore overrun errors if both
IGNPAR and IGNBRK are set.

I just followed the set_termios documentation, which says that IGNPAR is for parity and framing.
The current controller does not support break detection reliably.
That is probably why we don?t have IGNBRK.

My point is about how a user-space process tells the serial driver to ignore
overrun errors, as well, and not specifically about break handling.

Regards
Anirudha

quoted

Regards,
Peter Hurley

quoted

Signed-off-by: Anirudha Sarangi <redacted>
Signed-off-by: Michal Simek <redacted>
---

 drivers/tty/serial/xilinx_uartps.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/xilinx_uartps.c

b/drivers/tty/serial/xilinx_uartps.c
index a3020344ac9d..c4437e8929ff 100644

--- a/drivers/tty/serial/xilinx_uartps.c
+++ b/drivers/tty/serial/xilinx_uartps.c

@@ -691,7 +691,7 @@ static void cdns_uart_set_termios(struct uart_port

*port,

    if (termios->c_iflag & IGNPAR)
            port->ignore_status_mask |= CDNS_UART_IXR_PARITY |
-                   CDNS_UART_IXR_FRAMING |

CDNS_UART_IXR_OVERRUN;

quoted

+                                       CDNS_UART_IXR_FRAMING;

    /* ignore all characters if CREAD is not set */
    if ((termios->c_cflag & CREAD) == 0)

This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.