[PATCH 3/4] serial: xuartps: Do not enable parity error interrupt
From: Michal Simek <hidden>
Date: 2015-08-17 07:23:38
Also in:
linux-serial, lkml
Subsystem:
the rest, tty layer and serial drivers · Maintainers:
Linus Torvalds, Greg Kroah-Hartman, Jiri Slaby
From: Anirudha Sarangi <redacted> The patch makes changes not to enable parity error interrupt. With the current implementation, each parity error results in two distinct interrupts (almost always). The first one is normal parity error interrupt with no data in the fifo and the second one is a proper Rx interrupt with the received data in the fifo. By disabling parity error interrupt we still ensure handling of parity errors as for the Rx fifo interrupt the parity error still shows up in the interrupt status register. Considering the fact that the by default INPCK and IGNPAR are not set, this is the optimal implementation for parity error handling. Signed-off-by: Anirudha Sarangi <redacted> Signed-off-by: Michal Simek <redacted> --- drivers/tty/serial/xilinx_uartps.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
index c4437e8929ff..2dc26e5f1384 100644
--- a/drivers/tty/serial/xilinx_uartps.c
+++ b/drivers/tty/serial/xilinx_uartps.c@@ -803,8 +803,18 @@ static int cdns_uart_startup(struct uart_port *port) writel(readl(port->membase + CDNS_UART_ISR_OFFSET), port->membase + CDNS_UART_ISR_OFFSET); - /* Set the Interrupt Registers with desired interrupts */ - writel(CDNS_UART_IXR_TXEMPTY | CDNS_UART_IXR_PARITY | + /* + * Set the Interrupt Registers with desired interrupts. Do not + * enable parity error interrupt for the following reason: + * When parity error interrupt is enabled, each Rx parity error always + * results in 2 events. The first one being parity error interrupt + * and the second one with a proper Rx interrupt with the incoming data. + * Disabling parity error interrupt ensures better handling of parity + * error events. With this change, for a parity error case, we get a + * Rx interrupt with parity error set in ISR register and we still + * handle parity errors in the desired way. + */ + writel(CDNS_UART_IXR_TXEMPTY | CDNS_UART_IXR_FRAMING | CDNS_UART_IXR_OVERRUN | CDNS_UART_IXR_RXTRIG | CDNS_UART_IXR_TOUT, port->membase + CDNS_UART_IER_OFFSET);
--
2.3.5