On 07/17/2015 12:21 PM, Pavel Fedin wrote:

 Hello!

quoted

quoted

quoted

quoted

+	} else if (!msi->flags)
+		return -EINVAL;

 Did you mean "if (msg->flags)" here (inverted condition)?

Yes thanks for spotting this.

Thanks

Eric

quoted

Indeed, and also you need { } around the return for the QEMU coding
standard.

 It's kernel and not qemu :)

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia