Thread (28 messages) 28 messages, 4 authors, 2015-08-03
STALE3958d
Revisions (7)
  1. v1 [diff vs current]
  2. v2 [diff vs current]
  3. v2 [diff vs current]
  4. v2 [diff vs current]
  5. v2 current
  6. v2 [diff vs current]
  7. v3 [diff vs current]

[PATCH v2 3/7] KVM: irqchip: convey devid to kvm_set_msi

From: pbonzini@redhat.com (Paolo Bonzini)
Date: 2015-07-17 10:09:15
Also in: kvm, kvmarm


On 17/07/2015 09:27, Pavel Fedin wrote:
quoted
quoted
+	} else if (!msi->flags)
+		return -EINVAL;
 Did you mean "if (msg->flags)" here (inverted condition)?
Indeed, and also you need { } around the return for the QEMU coding
standard.

Paolo
quoted
quoted
+
+	/* historically the route.type was not set */
+
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help