[PATCH 1/9] gpiolib: Fix possible use of wrong name
From: johan@kernel.org (Johan Hovold)
Date: 2015-07-28 09:03:53
Also in:
linux-gpio
On Fri, Jul 17, 2015 at 11:32:42AM +0200, Markus Pargmann wrote:
The name is set optionally from DT. Therefore we need to reset the name variable for every loop iteration. Otherwise we could use a wrong or uninitialized name.
This doesn't make sense. of_get_gpio_hog falls back to using the node name so name will always be updated (unless there's an error). Could be better documented, though.
quoted hunk ↗ jump to hunk
Signed-off-by: Markus Pargmann <redacted> --- drivers/gpio/gpiolib-of.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c index 9a0ec48a4737..60aebe4d7c26 100644 --- a/drivers/gpio/gpiolib-of.c +++ b/drivers/gpio/gpiolib-of.c@@ -209,11 +209,11 @@ static void of_gpiochip_scan_hogs(struct gpio_chip *chip) { struct gpio_desc *desc = NULL; struct device_node *np; - const char *name; enum gpio_lookup_flags lflags; enum gpiod_flags dflags; for_each_child_of_node(chip->of_node, np) { + const char *name = NULL; if (!of_property_read_bool(np, "gpio-hog")) continue;
Johan