[PATCH v5 04/19] PCI/MSI: Add hooks to populate the msi_domain field

From
Bjorn Helgaas <bhelgaas@google.com>
Date
2015-07-23 15:37:22
Also in
linux-pci, lkml
Reply to
Marc Zyngier, 2015-07-23
On Thu, Jul 23, 2015 at 9:52 AM, Marc Zyngier [off-list ref] wrote:
On 23/07/15 14:06, Bjorn Helgaas wrote:
quoted
On Thu, Jul 23, 2015 at 10:26:23AM +0100, Marc Zyngier wrote:
quoted
In order to be able to populate the device msi_domain field,
add the necessary hooks to propagate the host bridge msi_domain
across secondary busses to devices.

So far, nobody populates the initial msi_domain.

Signed-off-by: Marc Zyngier <redacted>
Acked-by: Bjorn Helgaas <bhelgaas@google.com>
quoted
+static void pci_set_msi_domain(struct pci_dev *dev)
+{
+    /*
+     * If no domain has been set through the pcibios callback,
+     * inherit the default from the bus device.
Nit: there isn't a pcibios callback anymore.
There is actually one, in pci_add_device:

        [...]
        ret = pcibios_add_device(dev);
        WARN_ON(ret < 0);

        /* Setup MSI irq domain */
        pci_set_msi_domain(dev);
        [...]

pcibios_add_device is the one I was referring to. I'll clarify the comment.
Oh, right!  I thought you were referring to
pcibios_set_host_bridge_msi_domain(), which got removed, but of course
that wouldn't even make sense.
Thread (35 messages) 35 messages, 3 authors, last reply 2015-07-25
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help