[PATCH v2 1/2] input: touchscreen: pixcir_i2c_ts: Add support for optional wakeup interrupt
From: dmitry.torokhov@gmail.com (Dmitry Torokhov)
Date: 2015-07-20 06:24:14
Also in:
linux-devicetree, linux-input, linux-omap, lkml
On Sun, Jul 19, 2015 at 11:09:30PM -0700, Tony Lindgren wrote:
* Vignesh R [off-list ref] [150719 21:53]:quoted
@@ -445,6 +443,8 @@ static struct pixcir_ts_platform_data *pixcir_parse_dt(struct device *dev) dev_dbg(dev, "%s: x %d, y %d, gpio %d\n", __func__, pdata->x_max + 1, pdata->y_max + 1, pdata->gpio_attb); + pdata->wakeirq = of_irq_get_byname(dev->of_node, "wakeupirq"); + return pdata;What about handling -EPROVE_DEFER here? At least pinctrl-single can be be a loadable module for the dedicated wakeirqs.
Right. I think we should only allow -ENODATA to continue and return error in all other cases. Also, I think "irq" suffix on name is redundant. Thanks. -- Dmitry