Thread (46 messages) 46 messages, 9 authors, 2015-07-17

[PATCH 04/13] pinctrl: tegra: Only set the gpio range if needed

From: Alexandre Courbot <hidden>
Date: 2015-07-15 03:17:36
Also in: lkml

On Tue, Jul 14, 2015 at 5:34 PM, Tomeu Vizoso
[off-list ref] wrote:
On 13 July 2015 at 22:14, Linus Walleij [off-list ref] wrote:
quoted
On Wed, Jun 17, 2015 at 3:42 PM, Tomeu Vizoso
[off-list ref] wrote:
quoted
If the gpio DT node has the gpio-ranges property, the range will be
added by the gpio core and doesn't need to be added by the pinctrl
driver.

By having the gpio-ranges property, we have an explicit dependency from
the gpio node to the pinctrl node and we can stop using the deprecated
pinctrl_add_gpio_range() function.

Note that when the GPIO device gets probed before the associated
princtrl device, the gpio core actually won't register the gpio range.
Thus, this patch is only safe to be merged after we have in place a way
to assure that gpio devices are probed after their associated pinctrl
devices (such as ordered probing).

Signed-off-by: Tomeu Vizoso <redacted>
This doesn't look like it would hurt, but need Stephen's opinion
on it, and I think he's on vacation. Would check with next-in-line
Tegra maintainer, Thierry/Alexandre?
Sorry about that, but I have split these changes out into their own
series after people complained about it.

Have just sent a new version which already has Stephen's ack:

https://lkml.kernel.org/g/1436862596-27730-1-git-send-email-tomeu.vizoso at collabora.com
The change looks ok, but why limit it to Tegra? It seems like it could
apply to any driver that supports gpio-range. Or is it because this
will only work with drivers that use ordered probing?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help