[PATCH 1/7] pinctrl: UniPhier: add UniPhier pinctrl core support
From: Paul Bolle <hidden>
Date: 2015-07-07 09:14:48
Also in:
linux-gpio, lkml
(I only comment on 1/7, because it's not useful to repeat one remark seven times.) On ma, 2015-07-06 at 21:29 +0900, Masahiro Yamada wrote:
quoted hunk ↗ jump to hunk
--- /dev/null +++ b/drivers/pinctrl/uniphier/Kconfig
+config PINCTRL_UNIPHIER_CORE + bool + select PINMUX + select GENERIC_PINCONF
quoted hunk ↗ jump to hunk
--- /dev/null +++ b/drivers/pinctrl/uniphier/Makefile
+obj-$(CONFIG_PINCTRL_UNIPHIER_CORE) += pinctrl-uniphier-core.o
quoted hunk ↗ jump to hunk
--- /dev/null +++ b/drivers/pinctrl/uniphier/pinctrl-uniphier-core.c
+#include <linux/module.h>
+int uniphier_pinctrl_probe(struct platform_device *pdev,
+ struct pinctrl_desc *desc,
+ struct uniphier_pinctrl_socdata *socdata)
+{
+ [...]+ desc->owner = THIS_MODULE;
+ [...] +}
This series adds a number of bool Kconfig symbols. So, as far as I can see, the code it adds can only be built-in. This series also uses a number of module specific constructs (ie, THIS_MODULE, MODULE_DEVICE_TABLE, module_exit, MODULE_AUTHOR, MODULE_DESCRIPTION, and MODULE_LICENSE). So I wonder whether it was intended to make these new Kconfig symbols tristate instead? Thanks, Paul Bolle