Thread (20 messages) 20 messages, 4 authors, 2015-07-28

[PATCH v2 3/4] ARM: mvebu: Allow using the GIC for wakeup in standby mode

From: Gregory CLEMENT <hidden>
Date: 2015-07-03 07:18:58
Also in: linux-pm, lkml

Hi Thomas,

On 01/07/2015 17:54, Thomas Petazzoni wrote:
Dear Gregory CLEMENT,

On Tue, 30 Jun 2015 19:18:59 +0200, Gregory CLEMENT wrote:
quoted
 static void __init mvebu_init_irq(void)
 {
+	if (of_machine_is_compatible("marvell,armada375") ||
+	    of_machine_is_compatible("marvell,armada380") ||
+	    of_machine_is_compatible("marvell,armada390"))
What we really want to know is if we're using the GIC, so what about
instead:

	np = of_find_compatible_node(NULL, NULL, "arm,cortex-a9-gic");
	if (np)
		gic_set_irqchip_flags(IRQCHIP_SKIP_SET_WAKE |
				      IRQCHIP_MASK_ON_SUSPEND);
	of_node_put(np);

(Not even compile-tested).
Indeed it is better. I will make the change.

Thanks,

Gregory

Thanks,

Thomas

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help