Thread (22 messages) 22 messages, 4 authors, 2015-07-16

[PATCH 5/7] pinctrl: sh-pfc: Remove empty gpio_function_free()

From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
Date: 2015-06-30 09:34:15
Also in: linux-gpio, linux-sh

Hi Geert,

Thank you for the patch.

On Tuesday 30 June 2015 09:45:25 Geert Uytterhoeven wrote:
gpio_chip.free() is optional, and can just be left unimplemented.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
quoted hunk ↗ jump to hunk
---
Untested due to lack of hardware (used on sh only).
---
 drivers/pinctrl/sh-pfc/gpio.c | 5 -----
 1 file changed, 5 deletions(-)
diff --git a/drivers/pinctrl/sh-pfc/gpio.c b/drivers/pinctrl/sh-pfc/gpio.c
index 1be118e4865fd3f8..b8929b5e2fa26c53 100644
--- a/drivers/pinctrl/sh-pfc/gpio.c
+++ b/drivers/pinctrl/sh-pfc/gpio.c
@@ -286,17 +286,12 @@ static int gpio_function_request(struct gpio_chip *gc,
unsigned offset) return ret;
 }

-static void gpio_function_free(struct gpio_chip *gc, unsigned offset)
-{
-}
-
 static int gpio_function_setup(struct sh_pfc_chip *chip)
 {
 	struct sh_pfc *pfc = chip->pfc;
 	struct gpio_chip *gc = &chip->gpio_chip;

 	gc->request = gpio_function_request;
-	gc->free = gpio_function_free;

 	gc->label = pfc->info->name;
 	gc->owner = THIS_MODULE;
-- 
Regards,

Laurent Pinchart
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help