Hi Maxime,

On Tue, 03 Mar 2015, Maxime Coquelin wrote:

On 02/26/2015 02:10 PM, Peter Griffin wrote:

quoted

To allow UHS modes to work properly we need to provide the st specific
set_uhs_signaling callback function. This function differs from the
generic sdhci_set_uhs_signaling callback in that we need to configure
the correct delay depending on the UHS mode, and also set the V18_EN
bit.

<snip>

quoted

+	if (ret)
+		dev_warn(mmc_dev(host->mmc), "Error setting dll for clock\n");

Maybe you could  print the uhs value to know which mode it was
trying to set?

Yes good idea, I have made that change in v3.

quoted

+
+	dev_dbg(mmc_dev(host->mmc), "uhs %d, ctrl_2 %04X\n", uhs, ctrl_2);
+
+	sdhci_writew(host, ctrl_2, SDHCI_HOST_CONTROL2);
+}
 static u32 sdhci_st_readl(struct sdhci_host *host, int reg)
 {

@@ -283,6 +332,7 @@ static const struct sdhci_ops sdhci_st_ops = {
 	.set_bus_width = sdhci_set_bus_width,
 	.read_l = sdhci_st_readl,
 	.reset = sdhci_reset,
+	.set_uhs_signaling = sdhci_st_set_uhs_signaling,
 };
 static const struct sdhci_pltfm_data sdhci_st_pdata = {

Other than that, you can add my:
Acked-by: Maxime Coquelin <redacted>

Thanks, regards,

Peter.