Thread (23 messages) 23 messages, 3 authors, 2015-03-30

[PATCH v2 3/8] mmc: sdhci-st: Add delay management functions for top registers (eMMC).

From: peter.griffin@linaro.org (Peter Griffin)
Date: 2015-03-30 10:33:33
Also in: linux-devicetree, linux-mmc, lkml

Hi Maxime,

On Tue, 03 Mar 2015, Maxime Coquelin wrote:
On 02/26/2015 02:10 PM, Peter Griffin wrote:
quoted
Due to the tight timing constriants in some UHS modes, it is required to have
s/constriant/constraints/
Will fix.

<snip>
quoted
+
+static inline void st_mmcss_set_static_delay(void __iomem *ioaddr)
+{
+	if (ioaddr) {
Maybe you could do:
    if (!ioaddr)
        return;
Yes good idea, I have made that change in V3.
    writel_relaxed....
quoted
+		writel_relaxed(0x0, ioaddr + ST_TOP_MMC_DLY_CTRL);
+		writel_relaxed(ST_TOP_MMC_DLY_MAX,
+				ioaddr + ST_TOP_MMC_TX_CLK_DLY);
+	}
+}
+
+static inline void st_mmcss_set_dll(void __iomem *ioaddr)
+{
+	if (ioaddr) {
Ditto
regards,

Peter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help